Skip to content

Fix oneclick issues.#2326

Merged
joshuayao merged 3 commits intomainfrom
ze/fix
Nov 13, 2025
Merged

Fix oneclick issues.#2326
joshuayao merged 3 commits intomainfrom
ze/fix

Conversation

@ZePan110
Copy link
Copy Markdown
Collaborator

@ZePan110 ZePan110 commented Nov 13, 2025

Description

Fix oneclick issues.

Issues

https://github.com/opea-project/GenAIExamples/actions/runs/19187255017/job/55156256685

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)
  • Others (enhancement, documentation, validation, etc.)

Dependencies

List the newly introduced 3rd party dependency if exists.

Tests

https://github.com/opea-project/GenAIExamples/actions/runs/19321500664/job/55263726449

Signed-off-by: ZePan110 <ze.pan@intel.com>
Signed-off-by: ZePan110 <ze.pan@intel.com>
Signed-off-by: ZePan110 <ze.pan@intel.com>
Copilot AI review requested due to automatic review settings November 13, 2025 05:30
@github-actions
Copy link
Copy Markdown

Dependency Review

The following issues were found:
  • ❌ 1 vulnerable package(s)
  • ✅ 0 package(s) with incompatible licenses
  • ✅ 0 package(s) with invalid SPDX license definitions
  • ⚠️ 3 package(s) with unknown licenses.
See the Details below.

Vulnerabilities

one_click_deploy/requirements.txt

NameVersionVulnerabilitySeverity
urllib32.2.3urllib3 redirects are not disabled when retries are disabled on PoolManager instantiationmoderate
urllib3 does not control redirects in browsers and Node.jsmoderate

License Issues

one_click_deploy/requirements.txt

PackageVersionLicenseIssue Type
ruamel-yaml0.18.16NullUnknown License
ruamel-yaml-clib0.2.8NullUnknown License
certifi2025.11.12NullUnknown License

Scanned Files

  • one_click_deploy/requirements.txt

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the one-click deployment workflow to support multiple operating systems and pins dependency versions with cryptographic hashes for improved security and reproducibility.

Key changes:

  • Added OS selection capability (debian/openeuler) to the manual workflow
  • Converted requirements.txt to use pip-compile with hash verification for all dependencies
  • Created requirements.in as the source file for dependency specifications

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
one_click_deploy/requirements.txt Replaced simple dependency list with pip-compile generated pinned versions including SHA256 hashes for security
one_click_deploy/requirements.in New source file listing the three required dependencies for pip-compile
.github/workflows/manual-one-click-workflow.yml Added OS parameter to workflow allowing selection between debian and openeuler platforms

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ZePan110 ZePan110 changed the title Ze/fix Fix oneclick issues. Nov 13, 2025
@joshuayao joshuayao merged commit 090d53a into main Nov 13, 2025
28 of 32 checks passed
@joshuayao joshuayao deleted the ze/fix branch November 13, 2025 06:05
cogniware-devops pushed a commit to Cogniware-Inc/GenAIExamples that referenced this pull request Dec 19, 2025
Signed-off-by: ZePan110 <ze.pan@intel.com>
Signed-off-by: cogniware-devops <ambarish.desai@cogniware.ai>
cogniware-devops pushed a commit to Cogniware-Inc/GenAIExamples that referenced this pull request Dec 19, 2025
Signed-off-by: ZePan110 <ze.pan@intel.com>
Signed-off-by: cogniware-devops <ambarish.desai@cogniware.ai>
cogniware-devops pushed a commit to Cogniware-Inc/GenAIExamples that referenced this pull request Dec 19, 2025
Signed-off-by: ZePan110 <ze.pan@intel.com>
Signed-off-by: cogniware-devops <ambarish.desai@cogniware.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants